Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps #1702

Merged
merged 1 commit into from
Jun 15, 2022
Merged

update deps #1702

merged 1 commit into from
Jun 15, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 8, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kpango kpango changed the title update deps [WIP] update deps Jun 8, 2022
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the dependency/go/update-go-modules branch 3 times, most recently from 0b0be4b to 166a286 Compare June 8, 2022 11:38
vankichi
vankichi previously approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!

@vankichi vankichi self-requested a review June 9, 2022 00:16
@kpango kpango force-pushed the dependency/go/update-go-modules branch from 166a286 to 0ab383b Compare June 9, 2022 04:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/dependency%2Fgo%2Fupdate-go-modules/b2b4c0968d39c76f401a9070eb53070adb72b91a

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 9, 2022

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kpango kpango force-pushed the dependency/go/update-go-modules branch from 0ab383b to 5e37c2c Compare June 9, 2022 07:06
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/dependency%2Fgo%2Fupdate-go-modules/b65710689de725cb64ef5a5b90ab9bc49f3e70d9

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kpango kpango force-pushed the dependency/go/update-go-modules branch 2 times, most recently from b37341d to 88fc39a Compare June 15, 2022 00:39
@kpango kpango force-pushed the dependency/go/update-go-modules branch from 88fc39a to 2c72c5f Compare June 15, 2022 00:57
@kpango kpango force-pushed the dependency/go/update-go-modules branch from 2c72c5f to e2ee2bb Compare June 15, 2022 00:57
hlts2
hlts2 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpango kpango merged commit 23de8c1 into master Jun 15, 2022
@kpango kpango deleted the dependency/go/update-go-modules branch June 15, 2022 08:38
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@hlts2 hlts2 hlts2 approved these changes

@datelier datelier Awaiting requested review from datelier

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/makefile priority/low size/XXL team/sre SRE team type/dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @vankichi @hlts2